Increase event QPS as a quick workaround for deployment probers #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1510
💛 - Coveralls |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
@mikkeloscar does it make sense to have this contribution merged now? Is it still relevant? |
Contributor
|
Considering that this is more than 5 years old and not something I am aware have been raised as an issue. I would not merge it unless we have a clear and current need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #31 is not solved, our probers still have to rely on monitoring
Failed…events to figure out if the stackset is healthy. We currently determine if the events are 'old enough' by using a 1 minute range, but sinceEventBroadcasterhas some fancy QPS logic inside, it will start dropping event updates at some point. Let's increase it even further for now as a quick hack.