Skip to content

[BC] Add sf 7.0 and drop 4.4 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

[BC] Add sf 7.0 and drop 4.4 #29

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b363b54
[BC] Add sf 7.0 and drop 4.4
yoanm Sep 3, 2025
c9ba5c3
Fix
yoanm Sep 3, 2025
46f4f94
Move to actual version
yoanm Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions .github/workflows/reusable-CI-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,28 +62,32 @@ jobs:
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
- job-name: Up to date versions - Sf 5.4 case
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
Copy link
Owner Author

@yoanm yoanm Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️⚠️⚠️ REVERT THIS BEFORE MERGE ⚠️⚠️⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' --with 'yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0' --with 'yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0'
- job-name: Up to date versions - Sf 6.4 case
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
symfony-version: '5.4'
symfony-version: '6.4'
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
# Fix - symfony/yaml - Avoid issue with Sf YAML 6.4+ and Framework bundle
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '6.4' ) && '--with "symfony/yaml:~6.4.0"' || '' }}
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
- job-name: Bare minimum # => Lowest versions allowed by composer config
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
- job-name: Bare minimum - Sf 5.4 case
php-version: '${{ needs.fetch-supported-versions.outputs.php-min }}'
symfony-version: '5.4'
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
- job-name: Bare minimum - Sf 6.4 case
# Fix - Sf 6.4 require php 8.1 minimum !
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '6.4' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
php-version: ${{ ( needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.1' || needs.fetch-supported-versions.outputs.php-min }}
symfony-version: '6.4'
- job-name: Late PHP migration # => Highest symfony version with lowest php version allowed by composer config
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-max == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-max }}'
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
Copy link
Owner Author

@yoanm yoanm Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️⚠️⚠️ REVERT THIS BEFORE MERGE ⚠️⚠️⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

pkg-extra-constraints: --with 'yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0' --with 'yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0'
- job-name: Late Symfony migration # => Lowest symfony version with highest php version allowed by composer config
php-version: '${{ needs.fetch-supported-versions.outputs.php-max }}'
symfony-version: '${{ needs.fetch-supported-versions.outputs.symfony-min }}'
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
pkg-extra-constraints: --with 'behat/gherkin:~4.12.0' ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && '--with "symfony/yaml:~6.4.0"' || '' }}
steps:
- name: Check out code
uses: actions/checkout@v5
Expand Down Expand Up @@ -215,6 +219,7 @@ jobs:
--with "symfony/config:${SF_CONSTRAINT}" \
--with "symfony/dependency-injection:${SF_CONSTRAINT}" \
--with "symfony/http-kernel:${SF_CONSTRAINT}" \
--with 'yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0' --with 'yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0' \
&& make build

- name: ComposerRequireChecker
Expand Down Expand Up @@ -242,25 +247,29 @@ jobs:
php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-max }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: behat/gherkin:~4.12.0
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
Copy link
Owner Author

@yoanm yoanm Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️⚠️⚠️ REVERT THIS BEFORE MERGE ⚠️⚠️⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

pkg-extra-constraints: behat/gherkin:~4.12.0 yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0 yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0
- job-name: PHP with lowest supported Symfony versions
php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-min }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
pkg-extra-constraints: behat/gherkin:~4.12.0
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
pkg-extra-constraints: behat/gherkin:~4.12.0 yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0 yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-min == '5.4' && needs.fetch-supported-versions.outputs.php-next == '8.5' ) && 'symfony/yaml:~6.4.0' || '' }}
- job-name: Symfony with highest supported PHP version
php-version: ${{ needs.fetch-supported-versions.outputs.php-max }}
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
# Fix - symfony/yaml => Avoid issue between symfony/yaml and symfony/framework-bundle (not compatible with some versions due to incomplete function signatures)
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
pkg-extra-constraints: behat/gherkin:~4.12.0 yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0 yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0
- job-name: Symfony with lowest supported PHP version
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
# Fix - Sf 7.1 require php 8.2 minimum !
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.1' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
# Fix - yoanm/* - TODO - !! REVERT THIS BEFORE MERGE !! (once an actual version is available)
pkg-extra-constraints: behat/gherkin:~4.12.0 yoanm/symfony-jsonrpc-http-server-doc:dev-feature/increase-supported-versions-sf7.0 yoanm/symfony-jsonrpc-http-server:dev-feature/increase-supported-versions-sf7.0

steps:
- name: Check out code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/supported-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"php": {"min": "8.0", "max": "8.4", "next": "8.5"},
"symfony": {"min": "4.4", "max": "6.4", "next": "7.0"}
"symfony": {"min": "5.4", "max": "7.0", "next": "7.1"}
}
16 changes: 8 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@
},
"require": {
"php": "^8.0",
"symfony/config": "^4.4 || ^5.4 || ^6.0",
"symfony/dependency-injection": "^4.4 || ^5.4 || ^6.0",
"symfony/event-dispatcher-contracts": "^1.0 || ^2.0",
"symfony/http-kernel": "^4.4 || ^5.4 || ^6.0",
"symfony/config": "^5.4 || ^6.4 || ^7.0",
"symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0",
"symfony/event-dispatcher-contracts": "^2.0 || ^3.0",
"symfony/http-kernel": "^5.4 || ^6.4 || ^7.0",
"yoanm/jsonrpc-http-server-swagger-doc-sdk": "^v1.0",
"yoanm/jsonrpc-server-doc-sdk": "^v1.0",
"yoanm/symfony-jsonrpc-http-server-doc": "^1.1"
"yoanm/symfony-jsonrpc-http-server-doc": "^1.1 || dev-feature/increase-supported-versions-sf7.0"
Copy link
Owner Author

@yoanm yoanm Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️⚠️⚠️ REVERT THIS BEFORE MERGE ⚠️⚠️⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

},
"require-dev": {
"behat/behat": "^3.9.0,<=3.16.1",
Expand All @@ -48,9 +48,9 @@
"phpunit/php-code-coverage": "^9.2.4",
"phpunit/phpunit": "^9.0",
"squizlabs/php_codesniffer": "^3.5",
"symfony/event-dispatcher": "^4.4 || ^5.4 || ^6.0",
"symfony/framework-bundle": "^4.4 || ^5.4 || ^6.0",
"symfony/routing": "^4.4 || ^5.4 || ^6.0",
"symfony/event-dispatcher": "^5.4 || ^6.4 || ^7.0",
"symfony/framework-bundle": "^5.4 || ^6.4 || ^7.0",
"symfony/routing": "^5.4 || ^6.4 || ^7.0",
"yoanm/php-unit-extended": "^2.0.2"
},
"config": {
Expand Down