Disable retention by time for MLP consumers #28412
Conversation
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors retention period logic for important consumers and adds special handling for MLP (Message-Level Processing) consumers. The key change is converting a static helper function into a lambda expression within the ImportantConsumersNeedToKeepCurrentKey method and adding logic to treat MLP consumers as having infinite retention, similar to important consumers.
- Converted static
GetAvailabilityPeriodfunction to a lambdagetAvailabilityPeriodwithinImportantConsumersNeedToKeepCurrentKey - Added special case for MLP consumers to return
TDuration::Max()for their availability period, ensuring messages are not automatically deleted - Removed trailing whitespace on an empty line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
1 participant
Changelog entry
...
Changelog category
Description for reviewers
...