Initialize xds bootstrap configuration #28391
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for XDS (xDS) protocol configuration in YDB, enabling service mesh and dynamic configuration capabilities. The implementation allows XDS bootstrap configuration to be specified in the application config and automatically sets up the required gRPC environment variables.
Key Changes:
- Adds XDS bootstrap configuration support with protobuf message definitions for XDS servers, node identity, and credentials
- Implements automatic initialization of
GRPC_XDS_BOOTSTRAP_CONFIGenvironment variable from application configuration - Adds SSL target name override capability for gRPC client connections to support custom SSL validation
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/library/grpc/actor_client/grpc_service_settings.h | Adds SslTargetNameOverride field to gRPC client settings |
| ydb/library/grpc/actor_client/grpc_service_client.h | Applies SSL target name override to gRPC channel configuration |
| ydb/core/security/ticket_parser_impl.h | Configures SSL target name override for access service, user account service, and service account service clients |
| ydb/core/protos/config.proto | Defines XDS bootstrap configuration protobuf messages including servers, credentials, and node metadata |
| ydb/core/protos/auth.proto | Adds SSL target name override fields for authentication services |
| ydb/core/driver_lib/run/ut/ya.make | Adds new unit test file for XDS bootstrap initialization |
| ydb/core/driver_lib/run/run_ut.cpp | Implements comprehensive tests for XDS bootstrap configuration initialization |
| ydb/core/driver_lib/run/run.h | Declares InitializeXdsBootstrapConfig method |
| ydb/core/driver_lib/run/run.cpp | Implements XDS bootstrap config builder that converts protobuf to JSON and sets environment variable |
| ydb/core/config/init/init_ut.cpp | Adds tests for automatic XDS node ID and data center zone configuration; refactors test helper functions |
| ydb/core/config/init/init_impl.h | Implements logic to auto-populate XDS node ID from hostname and zone from data center configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 participants
Changelog entry
This PR adds support for XDS (xDS) protocol configuration in YDB, enabling service mesh and dynamic configuration capabilities. The implementation allows XDS bootstrap configuration to be specified in the application config and automatically sets up the required gRPC environment variables.
Changelog category
Description for reviewers