Fix build and improve Analytics #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
master
branch
2 times, most recently
from
08abf34 to
2081fcd
Compare
|
@RandomShaper Can you upgrade this one for 3.2.4 too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is multi-purpose, to address both issues I reported as well as some build problems at once.
Fixes #7.
Fixes #8.
UPDATE: Analytics' events expect non-float values to be
Longs, notIntegers, so the added change lets it parse those values correctly.UPDATE: Add Analytics methods related to user privacy control: reset data and start/stop collection.