Skip to content

Suppressing asynchronous exceptions to avoid app crashes #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hegbear wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suppressing asynchronous exceptions to avoid app crashes #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/src/page/network_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,12 +567,16 @@ class Response {
Future get content {
_contentFuture ??= _bodyLoadedCompleter.future.then((error) async {
if (error is Exception) throw error;
var response = await _networkApi
.getResponseBody(network.RequestId(request.requestId));
if (response.base64Encoded) {
return base64.decode(response.body);
} else {
return response.body;
try {
var response = await _networkApi
.getResponseBody(network.RequestId(request.requestId));
if (response.base64Encoded) {
return base64.decode(response.body);
} else {
return response.body;
}
} catch (message) {
_logger.fine('[Response.content] getResponse error: $message');
}
});
return _contentFuture;
Expand Down