Skip to content

Feedback from training session #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feedback from training session #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e234f
Merge master into a-c-2019
May 7, 2019
5e0c074
shift the focus of the exercise to parameter packs
xtofl May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp11training/cpp11training/7.variadic_templates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ TEST(tuples, DISABLED_i_can_transform_all_elements_of_a_tuple) {
}

namespace {
namespace detail {
std::string serialize(std::string s) {
return "string@'"+s+"'";
}
std::string serialize(int i){
return "int@"+std::to_string(i);
}
}

template<typename ...Ts>
std::string serialize(Ts ...ts) {
return "";
Expand All @@ -65,6 +74,8 @@ TEST(serialization, DISABLED_serialize_different_types)
// TODO: fill in serialize so that the test passes
// GOAL: get familiar with template parameter packs
// GOAL: learn how to expand a (single) parameter pack
// HINT: use recursion: add a degenerate case and the general case
// or work with `if constexpr(sizeof...(ts)==0)` somehow
// GRADE: INTERMEDIATE
EXPECT_EQ("", serialize());
EXPECT_EQ("int@1", serialize(1));
Expand Down