Skip to content

Trigger Re-Render when Scrollability Changes and PermanentTrack is Enabled #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Trigger Re-Render when Scrollability Changes and PermanentTrack is Enabled #172

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
178c5ad
Check if the status of whether scrolling is possible has changed, and…
SoprisAppsCI Mar 29, 2021
4b335b8
add prepare script to install fork correctly
SoprisAppsCI Mar 29, 2021
24b4f7a
really only need the build part
SoprisAppsCI Mar 29, 2021
edae1b6
revert for PR after testing in own app
SoprisAppsCI Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Scrollbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,12 @@ export default class Scrollbar extends React.Component<ScrollbarProps, Scrollbar

this.scrollValues = scrollState;

// Check if the status of whether scrolling is possible has changed, and if it has force a re-render. This handles
// the condition of permanentTracks enabled because otherwise we're depending on trackVisibility changing to trigger a re-render.
if (bitmask & (1 << 8) || bitmask & (1 << 9)) {
this.forceUpdate();
}

if (!props.native && bitmask & (1 << 15)) {
util.getScrollbarWidth(true);
this.forceUpdate();
Expand Down