Skip to content

Conversation

@apocelipes
Copy link
Contributor

"dataframe" requires full C++23 support from the compiler and standard library (especially ranges). Older versions of clang did not fully support C++23:

image

Fixes #8593
Fixes #7914
Fixes #6996

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @apocelipes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses build failures related to the dataframe package by updating its supported versions and strengthening the C++23 feature detection within the build system. It ensures that the build environment provides complete C++23 standard library support, particularly for std::ranges, which is crucial for dataframe's compilation. This resolves several reported build issues by preventing compilation with compilers that lack full C++23 compliance.

Highlights

  • Updated DataFrame Versions: Added support for dataframe library versions 3.7.0 and 3.6.0 in the xmake.lua configuration, expanding the available options for this package.
  • Enhanced C++23 Feature Check: Modified the build script to include a more comprehensive check for full C++23 support, specifically verifying the availability of std::ranges::contains to ensure all required range features are present.
  • Clarified C++23 Requirement: Updated the C++23 requirement message in the build configuration to explicitly state the need for 'fully support for c++23', providing clearer guidance on compiler capabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves a build issue for the dataframe package by enhancing the C++23 feature detection. By adding a check for std::ranges::contains, the build script now more accurately verifies full C++23 compiler and standard library support, which is a requirement for this package. The update to the assertion message provides clearer feedback on failure. Additionally, adding the latest package versions is a good maintenance update. The changes are correct and improve the robustness of the package definition.

@waruqi waruqi merged commit 3f2b811 into xmake-io:dev Nov 20, 2025
61 checks passed
@apocelipes apocelipes deleted the fix-dataframe branch November 20, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants