-
-
Notifications
You must be signed in to change notification settings - Fork 491
Auto-update usd to v25.11 #8631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the version of the Universal Scene Description (USD) package definition within the repository. The primary goal is to ensure that the project can leverage the latest features, bug fixes, and improvements available in the newest USD release, maintaining compatibility and providing access to an up-to-date dependency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the usd package to version v25.11. While the version update itself is straightforward, it overlooks existing version-specific logic within the package file. A compatibility check for a previous version has not been extended to the new version, which could lead to build failures for users on certain platforms. My review highlights this potential issue to ensure the package remains robust.
| add_urls("https://github.com/PixarAnimationStudios/USD/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/PixarAnimationStudios/USD.git") | ||
|
|
||
| add_versions("v25.11", "c37c633b5037a4552f61574670ecca8836229b78326bd62622f3422671188667") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated update adds version v25.11 but overlooks the version-specific compatibility check on lines 43-47. This check prevents build failures for v25.08 with the clang toolchain on Linux. This omission introduces a risk of build failures for v25.11 on that platform.
To prevent this, the check should be updated. If the incompatibility persists in v25.11, you could modify the check like this:
if package:version() and (package:version():eq("25.08") or package:version():eq("25.11")) and
package:is_plat("linux") and package:has_tool("cxx", "clang") then
raise("package(usd " .. package:version():__tostring() .. ") unsupported clang toolchain")
endIf the issue is resolved in v25.11, adding a comment to the existing check to clarify why it is specific to v25.08 would improve maintainability.
New version of usd detected (package version: v25.08, last github version: v25.11)