-
-
Notifications
You must be signed in to change notification settings - Fork 490
dynareadout: update url and add py-bind config #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Willaaaaaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating and expanding the build system for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the dynareadout package by changing its source URL to a mirror, removing old versions, and adding configuration for Python bindings. While these are good improvements, I've identified a critical issue in the new build script that will cause build failures under certain configurations. I have also suggested changing the default values for the new options to be opt-in, which is more conventional and provides a better user experience.
c022919 to
5b05c52
Compare
|
idk why:
|
a355324 to
5b05c52
Compare
#8585
Our mirror have no other versions. Even the currently existing version is not a repo-author released one.
https://dashboard.stablebuild.com/pypi-deleted-packages/pkg/dynareadout have some source code. But it neither has a
.gitfolder nor is well-structed. Even if we added them one by one manually, we can't guarantee they are the same as the old ones.