Skip to content

Conversation

@Willaaaaaaa
Copy link
Contributor

@Willaaaaaaa Willaaaaaaa commented Nov 15, 2025

#8585

why remove old versions? it will break some user projects.

Our mirror have no other versions. Even the currently existing version is not a repo-author released one.
https://dashboard.stablebuild.com/pypi-deleted-packages/pkg/dynareadout have some source code. But it neither has a .git folder nor is well-structed. Even if we added them one by one manually, we can't guarantee they are the same as the old ones.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating and expanding the build system for the dynareadout package. It introduces comprehensive xmake build configurations to support C, C++, and new Python bindings, while also updating the package's source URL to a mirror due to the original repository's status. The changes streamline the build process and expand the package's language support.

Highlights

  • New Build Configuration for Python Bindings: A new xmake.lua file has been introduced under port/ to define comprehensive build rules for the dynareadout C library, its C++ bindings, and new Python bindings utilizing pybind11.
  • Updated Source URL and Version Management: The package's download URL has been updated to point to an xmake-mirror repository, and the version list has been streamlined to include only the latest 24.07 release, removing many older versions.
  • Refactored Build Options and Defaults: Build configuration options have been renamed (e.g., cpp to cpp_bind), a new python_bind option has been added, and the profiling option now defaults to true. The thread_safe option has been removed, implying thread safety is now a default or always-on feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dynareadout package by changing its source URL to a mirror, removing old versions, and adding configuration for Python bindings. While these are good improvements, I've identified a critical issue in the new build script that will cause build failures under certain configurations. I have also suggested changing the default values for the new options to be opt-in, which is more conventional and provides a better user experience.

@Willaaaaaaa Willaaaaaaa force-pushed the patch-251115 branch 2 times, most recently from c022919 to 5b05c52 Compare November 15, 2025 14:00
@Willaaaaaaa
Copy link
Contributor Author

Willaaaaaaa commented Nov 15, 2025

idk why:

  • win x86/arm
note: the following packages are unsupported on windows/x86,
you can try running `xrepo update-repo` to update repositories or open a pr to improve these packages:
  -> pybind11 v3.0.1 [from:dynareadout, license:BSD-3-Clause]

note: the following packages are unsupported on windows/arm64,
you can try running `xrepo update-repo` to update repositories or open a pr to improve these packages:
  -> pybind11 v3.0.1 [from:dynareadout, license:BSD-3-Clause]
  • mac
error: @programdir/core/main.lua:274: @programdir/actions/build/main.lua:161: @programdir/modules/async/runjobs.lua:394: @programdir/modules/private/action/build/object.lua:100: @programdir/modules/core/tools/gcc.lua:1047: src/cpp/filesystem_bridge.hpp:28:10: fatal error: 'boost/filesystem.hpp' file not found
#include <boost/filesystem.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@star-hengxing star-hengxing merged commit 7a75241 into xmake-io:dev Nov 24, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants