Skip to content

fix: add undefined check for expr in parseItem function #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix: add undefined check for expr in parseItem function #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa7062f
fix: add undefined check for expr in parseItem function
ShawnAtActivate May 22, 2025
74d8a08
feat: update test coverage for undefined type
ShawnAtActivate May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ export const parse = (content: string) => {
}

const parseItem = (expr) => {
if(!expr) return;

if (expr.kind === 'string') {
return expr.value
}
Expand Down Expand Up @@ -155,7 +157,7 @@ const convertToDotsSyntax = (list) => {
const flatten = (items, context = '') => {
const data = {}

if (items === null) {
if (items === null || items === undefined) {
return data
}

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/lang/en/ignore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
return [
'empty_array' => [],
'null' => null,
'undefined' => undefined,
];
3 changes: 2 additions & 1 deletion test/loader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,12 @@ it('transforms class names and consts to .json', () => {
expect(lang['name']).toBe('Name');
});

it('ignores empty `array` or `null` translations', () => {
it('ignores empty `array`, `null`, or `undefined` translations', () => {
const lang = parse(fs.readFileSync(isolatedFixtures + '/lang/en/ignore.php').toString());

expect(lang['empty_array']).toBe(undefined);
expect(lang['null']).toBe(undefined);
expect(lang['undefined']).toBe(undefined);
});

it('checks if there is .php translations', () => {
Expand Down