Add new OOP interface to work with JWKs #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello xaicron.
I'm implementing currently OpenID google login and decided to rework your module a bit.
I've added additional functionality to work with JWK sets.
Example of such keys you can find here: https://www.googleapis.com/oauth2/v2/certs (your module worked with certs version 1: https://www.googleapis.com/oauth2/v1/certs).
Also, I've changed logic of loading Crypt modules to Class::Load (internally it uses Module::Runtime like you used). I made this change, because checking $::Module:: stash is not correct and does not work for some Moose programs.
e.g.:
use MongoDB will add a lot of crap to %::
_<constructor MongoDB::MongoClient::new (defined at /usr/lib64/perl5/vendor_perl/5.18.2/x86_64-linux-thread-multi/MongoDB/MongoClient.pm line 914)
But not actual MongoDB::MongoClient::
% perl -l ./test.pl | grep -E "^MongoDB::MongoClient::" | wc -l
0
I'm open for any comments and waiting for your approval of a merge request :)