Skip to content

#318 Add ESLint support and configure it to use Drupal standards. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

#318 Add ESLint support and configure it to use Drupal standards. #319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed7b7c5
#318 Add ESLint support and configure it to use Drupal standards.
hkirsman Oct 28, 2022
c6c9529
#318 Try out moving node.js install to custom image for faster Lando …
hkirsman Oct 31, 2022
ee142d6
#318 Make the custom PHP image name more generic.
hkirsman Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .lando.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ services:
# User random static high port for database connection.
portforward: 34567
appserver:
build_as_root:
# To be able to run ESLint with GrumPHP, we need Node.js on appserver.
- "apt-get update"
- "apt-get install -y nodejs"
Copy link
Member

@tormi tormi Oct 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid such things in a template - they slow down the build time. Perhaps we should consider using custom PHP images instead with nodejs included?

# Install dependencies when building lando.
build:
- "composer install"
Expand Down
3 changes: 3 additions & 0 deletions grumphp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ grumphp:
# PHPUnit will fail with 0 tests.
phpunit:
testsuite: unit
eslint:
Copy link
Member

@tormi tormi Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider other options as well like using Husky via node service.

bin: 'node_modules/.bin/eslint'
config: 'web/core/.eslintrc.passing.json'
extensions:
- Wunderio\GrumPHP\Task\PhpCompatibility\PhpCompatibilityExtensionLoader
- Wunderio\GrumPHP\Task\PhpCheckSyntax\PhpCheckSyntaxExtensionLoader
Expand Down
Loading