Skip to content

Don't require --force flag for deleting already trashed posts #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't require --force flag for deleting already trashed posts #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c5c12
Initial plan
Copilot Nov 8, 2025
eb56981
Skip --force requirement for already trashed posts
Copilot Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions features/post.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,23 @@ Feature: Manage WordPress posts
When I try the previous command again
Then the return code should be 1

Scenario: Deleting already trashed custom post type posts
When I run `wp post create --post_title='Test CPT post' --post_type='book' --porcelain`
Then STDOUT should be a number
And save STDOUT as {BOOK_POST_ID}

When I run `wp post update {BOOK_POST_ID} --post_status='trash'`
Then STDOUT should be:
"""
Success: Updated post {BOOK_POST_ID}.
"""

When I run `wp post delete {BOOK_POST_ID}`
Then STDOUT should be:
"""
Success: Deleted post {BOOK_POST_ID}.
"""

Scenario: Updating an invalid post should exit with an error
Given a WP install

Expand Down
1 change: 1 addition & 0 deletions src/Post_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@ protected function delete_callback( $post_id, $assoc_args ) {
$post_type = get_post_type( $post_id );

if ( ! $assoc_args['force']
&& 'trash' !== $status
&& ( 'post' !== $post_type && 'page' !== $post_type ) ) {
return [
'error',
Expand Down
Loading