Skip to content

Conversation

@imrraaj
Copy link

@imrraaj imrraaj commented May 27, 2024

This PR implements the exclude_revisions flag for wp db search command. This flag allows users to exclude revisions from the search results.

PR fixes following issues:

Usage

wp db search <search> [--tables=<tables>] [--exclude_revisions]

@imrraaj imrraaj marked this pull request as ready for review June 18, 2024 11:22
@imrraaj imrraaj requested a review from a team as a code owner June 18, 2024 11:22
* @var string[] Array of SQL mode names that are incompatible with WordPress.
*/
protected $sql_incompatible_modes = [
protected $sql_incompatible_modes = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert changes in this and similar unrelated lines? For fixing code sniffer issues, please use composer run phpcbf. It seems you are using separate sniffer rules here.

@ernilambar
Copy link
Member

@imrraaj Also can you please add Behat test for this new feature? Ref - https://make.wordpress.org/cli/handbook/contributions/pull-requests/#functional-tests

@imrraaj
Copy link
Author

imrraaj commented Jun 19, 2024

@ernilambar I'll do the necessary changes and I'll add the tests for the same

@imrraaj imrraaj marked this pull request as draft June 20, 2024 08:29
@imrraaj imrraaj marked this pull request as ready for review June 25, 2024 12:26
@fatihturan
Copy link

I hope you merge this into the new version of the WP CLI soon. I am still looking for a workaround to exclude revisions while exporting the database, but I can't find it yet.

@swissspidy swissspidy requested a review from Copilot November 2, 2025 14:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an --exclude_revisions flag to the wp db search command to filter out revision posts from search results in the wp_posts table.

Key changes:

  • Added --exclude_revisions parameter documentation to the search command
  • Implemented logic to exclude posts with post_type = 'revision' when the flag is enabled
  • Added test coverage for the new functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/DB_Command.php Added --exclude_revisions flag implementation with WHERE clause filtering for wp_posts table
features/db-search.feature Added test scenario verifying revision exclusion behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants