Skip to content

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Nov 17, 2025

Closes WOOMOB-1617

Description

Adds calling the actual endpoint to update the note.

Test Steps

  1. Download and install the app.
  2. Login to a store with bookings.
  3. Open the details of a booking.
  4. Note what the current text for the note is. It might be just the placeholder.
  5. Tap on the note.
  6. Edit the note.
  7. Tap done.
  8. Wait a couple of seconds.
  9. Force close the app.
  10. Navigate to the same booking and validate that the note is the updated one.

Screenshots

Simulator Screen Recording - iPhone 17 Pro - 2025-11-17 at 13 11 12


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@adborbas adborbas added this to the 23.8 milestone Nov 17, 2025
@adborbas adborbas added the type: task An internally driven task. label Nov 17, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 17, 2025

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 17, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16359-eb7d0f7
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commiteb7d0f7
Installation URL194urq553kiq8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas force-pushed the adborbas/woomob-1617-network branch from ef5fa42 to 174d39b Compare November 17, 2025 11:32
@adborbas adborbas added the category: tracks Related to analytics, including Tracks Events. label Nov 17, 2025
@adborbas adborbas marked this pull request as ready for review November 17, 2025 12:11
@adborbas adborbas changed the title Make network call [Bookings] Make network call to update booking note Nov 17, 2025
@itsmeichigo itsmeichigo self-assigned this Nov 18, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described ✅

Regarding the UX, I'm concerned about the lack of progress indicator when saving the note. Also, the optimistic update of the note seems more complicated than necessary. How about showing a loading indicator in place of the Done button when it's tapped? Then we'll need to display the error toast in that same screen instead of on the detail screen.

let onCommit: ((String) -> Void)?

init(text: Binding<String>, title: String? = nil) {
init(text: Binding<String>, title: String? = nil, onCommit: ((String) -> Void)? = nil) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Making onCommit async and return an optional Error would let us show the loading indicator on this screen and display error when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both addressed in b92bafd

@adborbas
Copy link
Contributor Author

@itsmeichigo could you please take an other look?

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely 💯 Thanks for the updates!

@itsmeichigo
Copy link
Contributor

Merging now to include this change into my last PR.

@itsmeichigo itsmeichigo merged commit 3422321 into trunk Nov 19, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the adborbas/woomob-1617-network branch November 19, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants