-
Notifications
You must be signed in to change notification settings - Fork 121
[Bookings] Make network call to update booking note #16359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
ef5fa42 to
174d39b
Compare
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as described ✅
Regarding the UX, I'm concerned about the lack of progress indicator when saving the note. Also, the optimistic update of the note seems more complicated than necessary. How about showing a loading indicator in place of the Done button when it's tapped? Then we'll need to display the error toast in that same screen instead of on the detail screen.
| let onCommit: ((String) -> Void)? | ||
|
|
||
| init(text: Binding<String>, title: String? = nil) { | ||
| init(text: Binding<String>, title: String? = nil, onCommit: ((String) -> Void)? = nil) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Making onCommit async and return an optional Error would let us show the loading indicator on this screen and display error when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both addressed in b92bafd
|
@itsmeichigo could you please take an other look? |
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works nicely 💯 Thanks for the updates!
|
Merging now to include this change into my last PR. |

Closes WOOMOB-1617
Description
Adds calling the actual endpoint to update the note.
Test Steps
Screenshots
RELEASE-NOTES.txtif necessary.