Skip to content

feat: enhance connect and background_recv methods to handle error #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

feat: enhance connect and background_recv methods to handle error #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/wokwi_client/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def __init__(self, token: str, url: str = TRANSPORT_DEFAULT_WS_URL):
self._recv_task: Optional[asyncio.Task[None]] = None
self._closed = False

async def connect(self) -> dict[str, Any]:
async def connect(self, throw_error: bool = True) -> dict[str, Any]:
self._ws = await websockets.connect(
self._url,
extra_headers={
Expand All @@ -49,7 +49,7 @@ async def connect(self) -> dict[str, Any]:
hello_msg = cast(HelloMessage, hello)
self._closed = False
# Start background message processor
self._recv_task = asyncio.create_task(self._background_recv())
self._recv_task = asyncio.create_task(self._background_recv(throw_error))
return {"version": hello_msg["appVersion"]}

async def close(self) -> None:
Expand Down Expand Up @@ -109,7 +109,7 @@ async def request(self, command: str, params: dict[str, Any]) -> ResponseMessage
finally:
del self._response_futures[msg_id]

async def _background_recv(self) -> None:
async def _background_recv(self, throw_error: bool = True) -> None:
try:
while not self._closed and self._ws is not None:
msg: IncomingMessage = await self._recv()
Expand All @@ -127,6 +127,16 @@ async def _background_recv(self) -> None:
except Exception as e:
warnings.warn(f"Background recv error: {e}", RuntimeWarning)

if throw_error:
self._closed = True
# Cancel all pending response futures
for future in self._response_futures.values():
if not future.done():
future.set_exception(e)
if self._ws:
await self._ws.close()
raise

async def _recv(self) -> IncomingMessage:
if self._ws is None:
raise WokwiError("Not connected")
Expand Down