Improve macOS Locale Detection for Chinese Language Support #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves the issue where the Qt application would default to English instead of Chinese when launched from Finder on macOS, even when the system language is set to Chinese. Key changes: - Added macOS-specific locale detection when environment variables are empty - Implemented fallback to Chinese locale when launched from Finder - Added support for user locale preference file (~/.android-file-transfer-locale-prefs) - Enhanced translation loading with multiple format support (zh_CN, zh-CN, zh) - Added proper locale format handling for macOS vs translation file naming Technical details: - Uses #ifdef Q_OS_MACOS to ensure Linux compatibility - Detects when LANG/LC_ALL environment variables are empty (Finder launch) - Auto-detects Chinese locale if zh_CN translation is available - Supports user preference override via preference file - Implements fallback: localeName -> hyphen format -> language code Testing: - Verified Chinese language loads correctly from Finder - Confirmed existing command-line behavior is preserved - Tested preference file functionality - Ensured Linux systems are unaffected by macOS-specific changes
whoozle
requested changes
Nov 1, 2025
wang93wei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the locale detection mechanism on macOS to properly support Chinese language when the application is launched from
Finder. The previous implementation relied on user preference files, which has been replaced with a more robust system-based
language detection approach.
Problem
On macOS, when launching the Qt application from Finder, environment variables (LANG, LC_ALL) are often not set, causing
QLocale::system()to default toen_USeven when the system language is set to Chinese. This resulted in the applicationdisplaying in English instead of the user's preferred Chinese language.
Solution
Replaced the preference file-based approach with direct system language detection using macOS-specific commands:
Key Changes
Testing
Files Modified
Technical Details
The implementation uses QProcess to execute macOS defaults commands and QRegularExpression to parse the output, converting formats
like "zh-Hans-CN" to Qt's "zh_CN" format.