-
Notifications
You must be signed in to change notification settings - Fork 117
Simplify and naturalize API signatures and return types (5.x) #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whitfin
wants to merge
18
commits into
main
Choose a base branch
from
issue-382
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Progress is good, but there are a few concerns that will span into other issues (see #382 (comment) for context). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually fix #382, but is heavily WIP.
The idea is to simplify the
CachexAPI to strip out all unnecessary tagging (i.e.{:ok, _}) and align more with Elixir's stdlib conventions with naming. All of the discussion is in the linked thread, but in particular here are some of the changes:ArgumentError!variants of infallible callsThis will be a large amount of changes, but I'll try to break things up so that it's a) easier to track and b) keep it tested throughout. This will be merged into
mainwhen ready, but definitely triggers the 5.x timeline and will not be released until 5.x is "done".There will be many breaking changes in this migration, but I'll try to keep it minimal. Several breaking changes are just "better", though.