Bypass blob URL partitioning for top-level self fetches #1879
Conversation
Implements the fetch spec sid of bypassing partitioning when a top-level blob URL document attempts to fetch itself. For more info see: w3c/FileAPI#210
fetch.bs
Outdated
| <ul class=brief> | ||
| <li><p><var>global</var> is a {{Window}} object; | ||
|
|
||
| <li><p><var>global</var>'s <a for=Window>navigable</a> is not null; |
There was a problem hiding this comment.
I wonder if there are cases where this would be null and you can get this far into a fetch. Hmm.
There was a problem hiding this comment.
Specifically where client is non-null but not associated with a Window object? Would worker fetches count here? Maybe even navigation requests themselves, with their reserved client machinery...
There was a problem hiding this comment.
I mirrored this off of the logic in https://fetch.spec.whatwg.org/#populate-request-from-client, but I'm not certain that the cases there are possible here as well...
fetch.bs
Outdated
| <li><p><var>requestEnvironment</var>'s <a for="environment">creation URL</a> | ||
| <a for=url>equals</a> <var>request</var>'s <a for=request>current URL</a>, |
There was a problem hiding this comment.
Do we want to ignore fragment identifiers here?
There was a problem hiding this comment.
Hmm, what are your thoughts on this?
In Chrome we implemented exact matching because that's how the media fetch breakage we were aiming to work around presented itself (when navigating to a blob URL with a media mime type, the media element src is always exactly the URL you navigated to, fragment included if present)... But for other cases I could see ignoring the fragment identifier be a reasonable thing to do.
There was a problem hiding this comment.
I'm okay with keeping it strict.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
|
|
||
| <li><p>Let <var>blob</var> be the result of <a>obtaining a blob object</a> given | ||
| <var>blobURLEntry</var> and <var>navigationOrEnvironment</var>. | ||
| <var>blobURLEntry</var> and <var>stringOrEnvironment</var>. |
There was a problem hiding this comment.
Just realized that stringOrEnvironment is undefined when request's client is null.
3 participants
Implements the fetch spec side of bypassing partitioning when a top-level blob URL document attempts to fetch itself. For more info see: w3c/FileAPI#210
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff