Make attachShadow() use the global registry by default #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly improves the reuse of custom elements in different registries. Tests: web-platform-tests/wpt#55248. Fixes #1407.
keithamus
approved these changes
Oct 4, 2025
Member
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
Yes +1; consider Mozilla interested.
Collaborator
Sounds reasonable to me. But I'd love if @dandclark could also take a look.
Quick thing: is there already an MDN issue filed for SCER overall? The existing page for |
mfreed7
approved these changes
Oct 6, 2025
dandclark
approved these changes
Oct 6, 2025
Member
Author
|
The original DOM PR (and HTML PR) has all the relevant pointers: #1341. |
Collaborator
Ahh great - thanks. MDN issue here: mdn/content#38266 |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 24, 2025
whatwg/dom#1409 changed where attachShadow() obtains its registry so the serialization should account for that as well. Tests: web-platform-tests/wpt#56134. Fixes #11892.
This was referenced Nov 24, 2025
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 24, 2025
…trees In whatwg/dom#1409 this was changed for attachShadow(), but we forgot to change the HTML parser at the same time. Tests: web-platform-tests/wpt#56134. Fixes #11947.
6 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 25, 2025
…trees In whatwg/dom#1409 this was changed for attachShadow(), but we forgot to change the HTML parser at the same time. Tests: web-platform-tests/wpt#56134. Fixes #11947.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 25, 2025
whatwg/dom#1409 changed where attachShadow() obtains its registry so the serialization should account for that as well. Tests: web-platform-tests/wpt#56134. Fixes #11892.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves the reuse of custom elements in different registries.
Tests: web-platform-tests/wpt#55248.
Fixes #1407.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff