-
Notifications
You must be signed in to change notification settings - Fork 32
feat(frontend): display model as displayName(modelId) in task model selector #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c3ba38
feat(frontend): display model as displayName(modelId) in task model s…
qdaxb e8931f4
Merge remote-tracking branch 'github/main' into wegent/model-selector…
qdaxb 3d75fa1
fix(frontend): require model selection for legacy teams without prede…
qdaxb 55832f2
fix: fix model select
qdaxb f52baea
Merge remote-tracking branch 'github/main' into wegent/model-selector…
qdaxb 0f233fd
Merge branch 'wegent/fix-model-required-for-legacy-teams' into wegent…
qdaxb 580fe1d
style: update model selector style
qdaxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Consolidate duplicate imports to function or file level.
The import
from app.schemas.kind import ModelRefappears twice in this function (lines 606 and 748). Move the import to the top of the function to avoid redundancy.Apply this diff to move the import to the function start:
) -> Dict[str, Any]: """ Update user Bot """ import logging logger = logging.getLogger(__name__) + from app.schemas.kind import ModelRef bot = (Then remove both inline imports:
# Update bot's modelRef bot_crd = Bot.model_validate(bot.json) - from app.schemas.kind import ModelRef - if bot_crd.spec.modelRef:# Update bot's modelRef to point to the new dedicated model bot_crd = Bot.model_validate(bot.json) - from app.schemas.kind import ModelRef - if bot_crd.spec.modelRef:🤖 Prompt for AI Agents