Add support for --useRobots crawler flag to Browsertrix #3029
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
approved these changes
Dec 1, 2025
Member
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
Working as expected! Tested the robots checking logging when the option is enabled.
I think we can come back to the --robotsAgent option if/when it is requested.
SuaYoo
reviewed
Dec 2, 2025
Member
SuaYoo
left a comment
SuaYoo
left a comment
There was a problem hiding this comment.
Minor copy text suggestions. And somewhat opinionated as an API user, if the field name included a verb like useRobots the field would be consistent with useSitemap and is slightly more self documenting.
Co-authored-by: sua yoo <sua@webrecorder.org>
Co-authored-by: sua yoo <sua@webrecorder.org>
tw4l
force-pushed
the
issue-2935-robots
branch
from
2795376 to
7a61027
Compare
emma-sg
approved these changes
Dec 2, 2025
tw4l
changed the title
ikreymer
pushed a commit
to webrecorder/browsertrix-crawler
that referenced
this pull request
Dec 2, 2025
Follow-up to #631 Based on feedback from webrecorder/browsertrix#3029 Renaming `--robots` to `--useRobots` will allow us to keep the Browsertrix backend API more consistent with similar flags like `--useSitemap`. Keeping `--robots` as it's a nice shorthand alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2935
Adds:
useRobots, thanks Sua for the suggestion)I have not added the
robotsAgentparam that the crawler also supports as it seems like a pretty niche use case at this point, but can add if we'd prefer to do it all in one go.Dependencies
Browsertrix Crawler 1.10 (not yet released as of writing this), which should include webrecorder/browsertrix-crawler#932