A couple of fixes for the CSS random() tests
#55867
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec states that "In random(A, B, C)... If C is infinite, the result is A." however this test previously expected the result to be NaN, the same as if B was infinite.
We expect the fixed value to be less than (not equal to) 1.
assert_{greater_than_equal|less_than} expects the actual value to
be given as a number rather than a string
wpt-pr-bot
requested review from
FremyCompany,
dbaron,
fantasai,
frivoal,
plinss and
tabatkins
tabatkins
reviewed
Nov 5, 2025
tabatkins
approved these changes
Nov 5, 2025
Contributor
tabatkins
left a comment
tabatkins
left a comment
There was a problem hiding this comment.
Added a suggestion for moving the removed invalid test into a valid test, but otherwise r+.
[the spec](https://drafts.csswg.org/css-values-4/#calc-range) states that "Parse-time range-checking of values is not performed within math functions, and therefore out-of-range values do not cause the declaration to become invalid". This means we should allow math functions that result in out of range results in <random-value-sharing> fixed values at parse time with the expectation that they will be clamped at compute time
Corresponds to w3c/csswg-drafts@f587be0 which updated the criteria for random arguments to be of consistent rather than same type
Calme1709
force-pushed
the
random-tests
branch
from
233f3c3 to
e03a08c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details