Add a lint for the NavigatorID mixin to disallow UA sniffing in tests #55865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
jonathan-j-lee
As a start, lightly change lint.rules.Regexp, making it a subclass of lint.rules.Rule, thus allowing it to use the generic lint.rules.Rule.error. With that done, we now pass the subpattern matches as the context to the error factor, allowing them to be used in the description, thus letting us give users better error descriptions.
gsnedders
force-pushed
the
lint-navigatorid
branch
from
1175c69 to
10bc7b7
Compare
We have a number of places where tests use UA sniffing when they have no reasonable reason to; we really shouldn't do this, as it just leads to more problems down the road when we're trying to get interoperability.
gsnedders
force-pushed
the
lint-navigatorid
branch
from
10bc7b7 to
8b66253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly motivated by #55864, this adds a lint in an attempt to discourage people from adding needless UA-sniffing branches to their tests.
This also in the first commit slightly refactors
lint.rules.Regexpto make it a subclass oflint.rules.Ruleso we can use the genericlint.rules.Rule.error, and then using that passes in the subpattern matches as the context to allow them to be used in the description, allowing us to give users better error messages.