Wait until h2 believes the stream is closed before removing the queue #55854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the effect and frequency of web-platform-tests#51981, where we frequently saw timeouts from the H2 server, because we no longer repeatedly create new threads and new queues when we receive further events after StreamEnded, or an event with a reference to a StreamEnded. See the state diagram in https://httpwg.org/specs/rfc9113.html#StreamStates, noting that receiving StreamEnded only closes the connection when the stream is in the half-closed (local) state. This also means we treat a stream as closed when we send/receive a RST_STREAM frame.
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
jonathan-j-lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the effect and frequency of #51981, where we frequently
saw timeouts from the H2 server, because we no longer repeatedly
create new threads and new queues when we receive further events after
StreamEnded, or an event with a reference to a StreamEnded.
See the state diagram in
https://httpwg.org/specs/rfc9113.html#StreamStates, noting that
receiving StreamEnded only closes the connection when the stream is in
the half-closed (local) state.
This also means we treat a stream as closed when we send/receive a
RST_STREAM frame.