-
Notifications
You must be signed in to change notification settings - Fork 199
Custom Media Queries - Add BCD #3533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # - css.at-rules.custom-media | ||
| # - api.CSSCustomMediaRule | ||
| # - api.CSSCustomMediaRule.name | ||
| # - api.CSSCustomMediaRule.query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to do a bit of explaining here. What happened with the other keys? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added only css.at-rules.custom-media to BCD, the other keys don't exist - no browser supports them.
See BCD v7.1.21 changelog: https://github.com/mdn/browser-compat-data/releases/tag/v7.1.21
You can also check the code: https://github.com/mdn/browser-compat-data/tree/v7.1.21/api
Currently, the CSSCustomMediaRule doesn't exist. Only the CSS @custom-media at-rule is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that the key css.at-rules.custom-media was added to BCD mdn/browser-compat-data#28438. But in this PR, you removed the comment for the other keys without explanation.
I went ahead and dug into this myself. I turned on the preference shown in the data and the CSSCustomMediaRule interface is exposed (there's also code for it in the diff from the Firefox bug you linked in BCD). So two things need to happen here:
- Against BCD, file an issue noting the missing keys or submit a PR to add the data for the missing API yourself.
- In this PR, reinstate the comment for the
api.CSSCustomMediaRulekey and its descendants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BCD PR: mdn/browser-compat-data#28450
I added the CSS
@custom-mediaat-rule in #3325 . But since no browser implemented this feature, we didn't addedcompat_featuresparam.Now, Firefox 147 became the first browser to support this feature https://bugzilla.mozilla.org/show_bug.cgi?id=1744292
I updated the BCD project to reflect this change mdn/browser-compat-data#28438
This PR updates the
custom-media-queriesweb feature setting thecompat_featuresparam.