Skip to content

fix: compile message not relayed by wrapper (#299) #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: compile message not relayed by wrapper (#299) #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/ipc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ChildProcess } from 'child_process'
import type { CompileParams } from './compiler'

export type IPCMessage = {
cmd?: string
Expand All @@ -12,10 +13,17 @@ export type IPCMessage = {
/**
* Checks if the given message is an internal node-dev message.
*/
function isNodeDevMessage(m: IPCMessage) {
function isNodeDevMessage(m: any): m is IPCMessage {
return m.cmd === 'NODE_DEV'
}

/**
* Check if the given message is an compile request message.
*/
function isCompileRequestMessage(m: any): m is CompileParams {
return typeof m.compile === 'string' && typeof m.compiledPath === 'string'
}

/**
* Sends a message to the given process.
*/
Expand All @@ -29,7 +37,7 @@ export const on = function (
type: string,
cb: (m: IPCMessage) => void
) {
function handleMessage(m: IPCMessage) {
function handleMessage(m: any) {
if (isNodeDevMessage(m) && type in m) cb(m)
}
proc.on('internalMessage', handleMessage)
Expand All @@ -40,8 +48,8 @@ export const relay = function (
src: ChildProcess,
dest: NodeJS.Process = process
) {
function relayMessage(m: IPCMessage) {
if (isNodeDevMessage(m)) dest.send!(m)
function relayMessage(m: any) {
if (isNodeDevMessage(m) || isCompileRequestMessage(m)) dest.send!(m)
}
src.on('internalMessage', relayMessage)
src.on('message', relayMessage)
Expand Down