Skip to content

Conversation

@infomiho
Copy link
Member

@infomiho infomiho commented Oct 7, 2025

Description

Based on #531

Fixes #524

This PR reuses the existing dope.sh to create a testable app from an app generated by wasp new app -t saas.

The changes are minimal:

  • change Dummy to SMTP and use the correct email address
  • setup Dotenv Vault

This allows for testing the app in production mode e.g. npx @wasp.sh/wasp-app-runner build.

This PR doesn't setup Stripe, analytics or similar. I think it's not really needed to smoke test the template. We have opensaas.sh with all the bell and whistles for that.

Contributor Checklist

Make sure to do the following steps if they are applicable to your PR:

@infomiho infomiho force-pushed the production-template-testing branch from 744df97 to 3647c22 Compare October 7, 2025 11:47
@infomiho infomiho mentioned this pull request Oct 7, 2025
4 tasks
@infomiho infomiho changed the base branch from main to extract-dope-sh-to-top-level October 7, 2025 11:48
@infomiho infomiho force-pushed the extract-dope-sh-to-top-level branch 2 times, most recently from 8c03552 to 1159ea4 Compare October 7, 2025 11:54
@infomiho infomiho force-pushed the production-template-testing branch from 3647c22 to 8aaf842 Compare October 7, 2025 11:55
@infomiho infomiho marked this pull request as ready for review October 7, 2025 12:10
@infomiho infomiho requested a review from sodic October 7, 2025 12:28
@cprecioso
Copy link
Member

@infomiho haven't looked at anything here, but wanted to pop in; if we're going to be using dope.sh more extensively, might it make sense to migrate it to a more understandable (and less edge-casey) language? We can take advantage of the fact that node is already installed...

@infomiho infomiho force-pushed the extract-dope-sh-to-top-level branch from 1159ea4 to 01c159c Compare October 7, 2025 15:16
@infomiho infomiho force-pushed the production-template-testing branch from 6c8d6e7 to 6a51600 Compare October 7, 2025 15:17
@infomiho
Copy link
Member Author

infomiho commented Oct 7, 2025

@cprecioso I think that the natural journey of all of our scripts -> inline -> bash -> Node.js

I wouldn't do it in this PR though, I'd create an issue if we agree that we want to do it.

@cprecioso
Copy link
Member

@infomiho My vote is to even do that before this PR here. As you see fit.

@Martinsos
Copy link
Member

+1 for the idea of rewrite at some point but also big +1 for not doing it now, priorities again, dope.sh works fine and is tested through use, no need to shake that tree at the moment.

@infomiho infomiho force-pushed the production-template-testing branch 2 times, most recently from eb64c15 to 0363f98 Compare October 10, 2025 15:17
@infomiho infomiho changed the base branch from extract-dope-sh-to-top-level to main October 10, 2025 15:18
Copy link
Collaborator

@sodic sodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It solves the most annoying and the longest part of release testing (at least to me).

I do have some questions and suggestions, check the comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a very similar thing in opensaas-sh/tools. Can we consolidate them and somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are actually quite different:

  • opensaas-sh/tools script can use the template dir it has available on the disk
  • template-test/toolsscript needs to run wasp new each time to get the template

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fair enough.

I thought the differences were maybe coming from us forgetting to do some stuff in one of the scripts (e.g., the trap thing). But if they're that different because they really are different, then all good.

RAW.

@infomiho infomiho force-pushed the production-template-testing branch from 583ae2a to ba1a968 Compare November 5, 2025 13:45
@infomiho infomiho changed the base branch from main to fix/dope-empty-deletions November 5, 2025 13:45
@infomiho infomiho force-pushed the production-template-testing branch from d8a5b73 to 6490564 Compare November 5, 2025 14:41
@infomiho infomiho changed the base branch from fix/dope-empty-deletions to main November 5, 2025 14:42
@infomiho infomiho requested a review from sodic November 5, 2025 14:50
Copy link
Collaborator

@sodic sodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify testing the Open Saas template in build mode

5 participants