-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use dope.sh to generate a testable app from production template
#530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
744df97 to
3647c22
Compare
8c03552 to
1159ea4
Compare
3647c22 to
8aaf842
Compare
|
@infomiho haven't looked at anything here, but wanted to pop in; if we're going to be using |
1159ea4 to
01c159c
Compare
6c8d6e7 to
6a51600
Compare
|
@cprecioso I think that the natural journey of all of our scripts -> inline -> bash -> Node.js I wouldn't do it in this PR though, I'd create an issue if we agree that we want to do it. |
|
@infomiho My vote is to even do that before this PR here. As you see fit. |
|
+1 for the idea of rewrite at some point but also big +1 for not doing it now, priorities again, dope.sh works fine and is tested through use, no need to shake that tree at the moment. |
eb64c15 to
0363f98
Compare
sodic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! It solves the most annoying and the longest part of release testing (at least to me).
I do have some questions and suggestions, check the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a very similar thing in opensaas-sh/tools. Can we consolidate them and somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are actually quite different:
opensaas-sh/toolsscript can use thetemplatedir it has available on the disktemplate-test/toolsscript needs to runwasp neweach time to get the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fair enough.
I thought the differences were maybe coming from us forgetting to do some stuff in one of the scripts (e.g., the trap thing). But if they're that different because they really are different, then all good.
RAW.
template-test/app_diff/migrations/20251007102522_init/migration.sql.diff
Outdated
Show resolved
Hide resolved
583ae2a to
ba1a968
Compare
d8a5b73 to
6490564
Compare
sodic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!

Description
Based on #531
Fixes #524
This PR reuses the existing
dope.shto create a testable app from an app generated bywasp new app -t saas.The changes are minimal:
DummytoSMTPand use the correct email addressThis allows for testing the app in production mode e.g.
npx @wasp.sh/wasp-app-runner build.This PR doesn't setup Stripe, analytics or similar. I think it's not really needed to smoke test the template. We have
opensaas.shwith all the bell and whistles for that.Contributor Checklist