Editorial: remove unnecessary CacheStorage global object definition #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the specific definition of the global object for CacheStorage and replaces the incorrect and redundant reference to the environment settings object with a more direct reference to the relevant settings object. Fixes w3c#1791
Collaborator
Author
|
@domenic This addresses #1791. Will you take a look? |
domenic
approved these changes
Sep 10, 2025
Addressed the comment. Co-authored-by: Domenic Denicola <d@domenic.me>
monica-ch
approved these changes
Sep 10, 2025
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Sep 11, 2025
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the specific definition of the global object for CacheStorage and replaces the incorrect and redundant reference to the environment settings object with a more direct reference to the relevant settings object.
Fixes #1791
Preview | Diff