Refactor route parameter access in [id].vue #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Enokisan 本リポジトリは昨年の Vue Fes Japan 2024 用にforkしたものとなり、現在は本家に取り込まれている状態です。 |
Author
|
ご案内いただきありがとうございます！ こちらで再度PRを出しました。何卒よろしくお願いいたします！（こちらはクローズします） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed
route.params.idretrieval fromcomputed()to direct reference.Reason
Since Vue Router's
route.paramsis already reactive, there's no need to wrap it withcomputed().This makes the code simpler and more readable.
Impact
None. It will continue to work the same way as before.