Let timer_wrapper support a list of commands #595
Merged
+30
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was currently not possible to provide an array of commands for a
timer's service to run e.g
```puppet
systemd::timer_wrapper{'purgescratch':
ensure => present,
command => [
"/usr/bin/find /koji/scratch -xdev -depth -mtime +365 ( -type f -o -type l ) -delete -o -type d -empty -delete",
"/usr/bin/find /koji/work -xdev -depth -mtime +365 ( -type f -o -type l ) -delete -o -type d -empty -delete",
]
on_calendar => 'Daily',
}
```
Support arrays of commands
bastelfreak
reviewed
Nov 26, 2025
Comment on lines
+42
to
+44
| Optional[Variant[Systemd::Unit::Service::Exec,Array[Systemd::Unit::Service::Exec,1]]] $pre_command = undef, | ||
| Optional[Variant[Systemd::Unit::Service::Exec,Array[Systemd::Unit::Service::Exec,1]]] $command = undef, | ||
| Optional[Variant[Systemd::Unit::Service::Exec,Array[Systemd::Unit::Service::Exec,1]]] $post_command = undef, |
Member
There was a problem hiding this comment.
Maybe that's the point where this should go into a custom type alias? :D
in your example you use:
['/usr/bin/echo run this', '/usr/bin/echo and this']
I'm wondering if the array will confuse because because they will actually do:
['/usr/bin/echo', 'run', 'this']
because of the exec resource, which accepts arrays for a single command + parameters.
Contributor
Author
There was a problem hiding this comment.
It will write it out as
ExecStart=/usr/bin/echo run this
ExecStart=/usr/bin/echo and this
its not an actual exec
kenyon
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
It was currently not possible to provide an array of commands for a timer's service to run e.g
Support arrays of commands