-
-
Notifications
You must be signed in to change notification settings - Fork 0
Prepare module for adoption by voxpupuli #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the module forked instead of transferred?
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
The version will be bumped during the voxpup release process
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Voxpup autogenerates their changelogs
I'm _so_ glad this isn't needed any more
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
Because the Adopting a "puppetlabs" module process requires us to fork our own version and put it on the Forge first. Then they review the module, deprecate their version from the Forge, and point to ours |
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
| "ref": "master" | ||
| symlinks: | ||
| "puppet_authorization": "#{source_dir}" | ||
| repo: "https://github.com/voxpupuli/puppet-hocon.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probably bite us later on. maybe we should first merge pr hocon pr and then clean this up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bastelfreak voxpupuli/puppet-hocon#1 should be ready for merge now 👍
|
As far as I can tell, this looks like a reasonably straightforward port 👍 |
|
@ekohl totally happy to talk about the process. Tbh, it was designed for adoption by unknowns, so if preferred, I think we can vastly simplify it for Vox. I'm happy to just transfer it if y'all want that instead. |
|
That sounds great. I think that means we have to delete this fork and then transfer it. Also, given the dependency chain I'd prefer to start with puppetlabs-hocon and then update puppetlabs-puppet_authorization. |
|
@binford2k arent those two modules used by PE? Some months ago there was a discuasion in slack about hocon and puppet_authorization modules and the idea was to unarchive them because a commercial product drom Puppet uses them. I dont know if thats still the case. |
|
@binford2k Do you happen to have an update regarding the transfer? I agree with @bastelfreak that PE seems to use this but it needs to be updated regularly to stay viable as a public module. |
No description provided.