Skip to content

Conversation

@op-ct
Copy link
Collaborator

@op-ct op-ct commented Aug 10, 2022

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the module forked instead of transferred?

op-ct and others added 7 commits August 10, 2022 11:01
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
The version will be bumped during the voxpup release process
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Voxpup autogenerates their changelogs
I'm _so_ glad this isn't needed any more
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
@op-ct
Copy link
Collaborator Author

op-ct commented Aug 10, 2022

Why was the module forked instead of transferred?

Because the Adopting a "puppetlabs" module process requires us to fork our own version and put it on the Forge first. Then they review the module, deprecate their version from the Forge, and point to ours

"ref": "master"
symlinks:
"puppet_authorization": "#{source_dir}"
repo: "https://github.com/voxpupuli/puppet-hocon.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably bite us later on. maybe we should first merge pr hocon pr and then clean this up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak voxpupuli/puppet-hocon#1 should be ready for merge now 👍

@trevor-vaughan
Copy link

As far as I can tell, this looks like a reasonably straightforward port 👍

@binford2k
Copy link
Member

@ekohl totally happy to talk about the process. Tbh, it was designed for adoption by unknowns, so if preferred, I think we can vastly simplify it for Vox. I'm happy to just transfer it if y'all want that instead.

@ekohl
Copy link
Member

ekohl commented Aug 29, 2022

That sounds great. I think that means we have to delete this fork and then transfer it.

Also, given the dependency chain I'd prefer to start with puppetlabs-hocon and then update puppetlabs-puppet_authorization.

@bastelfreak
Copy link
Member

@binford2k arent those two modules used by PE? Some months ago there was a discuasion in slack about hocon and puppet_authorization modules and the idea was to unarchive them because a commercial product drom Puppet uses them. I dont know if thats still the case.

@trevor-vaughan
Copy link

@binford2k Do you happen to have an update regarding the transfer? I agree with @bastelfreak that PE seems to use this but it needs to be updated regularly to stay viable as a public module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants