URL Cleanup

docs/go.adoc

@@ -133,7 +133,7 @@ $ govendor test +local
 ----
 
 Tests are written using the link:https://onsi.github.io/ginkgo/[Ginkgo] BDD testing framework
-and the link:http://onsi.github.io/gomega/[Gomega] matcher library, which are included in the `/vendor`
+and the link:https://onsi.github.io/gomega/[Gomega] matcher library, which are included in the `/vendor`
 directory.
 
 To run tests using Ginkgo, install the executable as follows (unless you did that already):

download/cache/cache_test.go

@@ -43,7 +43,7 @@ const (
 	cfHomeProperty = "CF_HOME"
 	homeProperty   = "HOME"
 	errMessage     = "worse things happen at sea"
-	urlValue       = "http://host/path/file.extension"
+	urlValue       = "https://host/path/file.extension"
 )
 
 var (

download/cache/etag_index_test.go

@@ -13,8 +13,8 @@ import (
 
 var _ = Describe("EtagIndex", func() {
 	const (
-		url1  = "http://url.1"
-		url2  = "http://url.2"
+		url1  = "https://url.1"
+		url2  = "https://url.2"
 		etag1 = "etag1"
 		etag2 = "etag2"
 	)

download/download_test.go

@@ -42,7 +42,7 @@ const (
 	ifNoneMatchHeader = "If-None-Match"
 	etagHeader        = "ETag"
 	etagValue         = "etag"
-	urlValue          = "http://some/remote/file"
+	urlValue          = "https://some/remote/file"
 	checksumValue     = "checksum"
 	testFilePath      = "/some/path"
 )
@@ -129,7 +129,7 @@ var _ = Describe("Download", func() {
 					})
 
 					It("should propagate the error", func() {
-						Expect(err).To(MatchError(fmt.Sprintf(`CreateHttpRequest for download URL "http://some/remote/file" failed: %s`, errMessage)))
+						Expect(err).To(MatchError(fmt.Sprintf(`CreateHttpRequest for download URL "https://some/remote/file" failed: %s`, errMessage)))
 					})
 				})
 
@@ -190,7 +190,7 @@ var _ = Describe("Download", func() {
 					})
 
 					It("should propagate the error", func() {
-						Expect(err).To(MatchError(fmt.Sprintf(`Download from URL "http://some/remote/file" failed: %s`, errMessage)))
+						Expect(err).To(MatchError(fmt.Sprintf(`Download from URL "https://some/remote/file" failed: %s`, errMessage)))
 					})
 				})
 
@@ -435,7 +435,7 @@ var _ = Describe("HttpResponse", func() {
 
 var _ = Describe("CreateHttpRequest", func() {
 	It("should return a suitable error when the method is unknown", func() {
-		_, err := download.NewHttpHelper().CreateHttpRequest("bad method", "http://example.com")
+		_, err := download.NewHttpHelper().CreateHttpRequest("bad method", "https://example.com")
 		Expect(err).To(MatchError(`net/http: invalid method "bad method"`))
 	})
 })