[BugFix] Fix PP/async scheduling with pooling models #28899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <nhill@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug related to pipeline parallelism and asynchronous scheduling for pooling models. The changes correctly prevent pooling models from going through the token sampling pipeline, which is intended only for generative models. The introduction of the is_pooling_model flag in vllm/v1/engine/core.py and the uses_sampler flag in vllm/v1/executor/ray_executor.py makes the code's intent clearer and fixes the incorrect behavior. The changes are logical, well-targeted, and appear to resolve the issue effectively. I have no further suggestions.
noooop
approved these changes
Nov 18, 2025
Member
Author
|
The two test failure here are unrelated:
|
bigPYJ1151
pushed a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Nick Hill <nhill@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: jiang1.li <jiang1.li@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by #28768. This wasn't exercised by the CI that ran on that PR.