[Minor] Rename ec_producer field to is_ec_producer
#28884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <nhill@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly renames the ec_producer field to is_ec_producer in vllm/v1/engine/core.py. This change improves code clarity and follows Python's naming conventions for boolean variables.
However, the refactoring appears to be incomplete. I've noticed that vllm/v1/executor/ray_executor.py still uses the old ec_producer name. To ensure consistency across the codebase and prevent potential confusion or bugs in the future, I recommend renaming self.ec_producer to self.is_ec_producer in vllm/v1/executor/ray_executor.py as well. Specifically, the definition at lines 103-106 and its usage at line 404 should be updated.
WoosukKwon
approved these changes
Nov 17, 2025
Victor49152
pushed a commit
to Victor49152/vllm
that referenced
this pull request
Nov 20, 2025
…28884) Signed-off-by: Nick Hill <nhill@redhat.com>
bhagyashrigai
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Nov 20, 2025
…28884) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Bhagyashri <Bhagyashri.Gaikwad2@ibm.com>
bigPYJ1151
pushed a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: jiang1.li <jiang1.li@intel.com>
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
…28884) Signed-off-by: Nick Hill <nhill@redhat.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…28884) Signed-off-by: Nick Hill <nhill@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this review comment from #28768.