[Doc] Fix failing doc build #28772
Merged
[Doc] Fix failing doc build #28772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
|
Documentation preview: https://vllm--28772.org.readthedocs.build/en/28772/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a failing documentation build by removing a broken anchor from a link in docs/configuration/serve_args.md. The change is correct and resolves the issue that was causing the build to fail. I have no further comments as the change is sufficient and correct.
Member
Author
|
I can't seem to pinpoint the cause of this issue. The last docs PR was #28731 which passed the build after merging: https://app.readthedocs.org/projects/vllm/builds/30326869/ Maybe it is an external dependency? cc @hmellor |
noooop
approved these changes
Nov 15, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
approved these changes
Nov 15, 2025
Member
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
This LGTM now if the docs build passes
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
bwasti
pushed a commit
to bwasti/vllm
that referenced
this pull request
Nov 17, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Bram Wasti <bwasti@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix https://app.readthedocs.org/projects/vllm/builds/30330079/
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.