[RL] [V1] Remove unused device argument from reset_kv_cache #28766
Conversation
Signed-off-by: Zhuohan Li <zhuohan123@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to remove the unused device argument from the reset_prefix_cache method across various components. The changes in the modified files are consistent with this goal. However, there is a critical issue: the base class EngineClient in vllm/engine/protocol.py has not been updated. This will cause a signature mismatch for the reset_prefix_cache method in the AsyncLLM class, which inherits from EngineClient. This file needs to be included in the pull request with the necessary changes to ensure the code compiles and runs correctly.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused device argument from the reset_prefix_cache function across multiple files. The changes are consistent, simplifying the function signatures and removing unnecessary logic. This refactoring improves code clarity and maintainability. I noticed a minor discrepancy: the pull request title refers to reset_kv_cache, while the changes and description correctly target reset_prefix_cache. You may want to update the title for consistency. Overall, the changes are well-executed and I have no further comments.
DarkLight1337
added
the
ready
|
Doc failure is unrelated - merging |
…ject#28766) Signed-off-by: Zhuohan Li <zhuohan123@gmail.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
…ject#28766) Signed-off-by: Zhuohan Li <zhuohan123@gmail.com> Signed-off-by: Bram Wasti <bwasti@meta.com>
…ject#28766) Signed-off-by: Zhuohan Li <zhuohan123@gmail.com>
…ject#28766) Signed-off-by: Zhuohan Li <zhuohan123@gmail.com>
…ject#28766) Signed-off-by: Zhuohan Li <zhuohan123@gmail.com>
Purpose
The device argument for
reset_prefix_cacheis no longer being used in V1.Test Plan
Existing tests should pass.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.