Skip to content

Run macos smoke test workflow on main commit #28752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 18, 2025
Merged

Run macos smoke test workflow on main commit #28752

merged 7 commits into from
Nov 18, 2025

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Nov 14, 2025 •
edited by github-actions bot
Loading

Purpose

Fix the .github/workflows/macos-smoke-test.yml workflow and enable it for commits on main

Test Plan

Test Result

Manually triggered https://github.com/vllm-project/vllm/actions/runs/19441781126/job/55626564074

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mgoin
Fix macos smoke test workflow
6199571 
Signed-off-by: Michael Goin <mgoin64@gmail.com>
@mergify mergify bot added the ci/build label Nov 14, 2025
mgoin added 6 commits November 14, 2025 15:39
@mgoin
Fix
ff600b1 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
Fix attn impl
161a4e9 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
Merge branch 'main' into macos-smoke-test-green
e64bf88 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
Fix system python
2f4a6b6 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
Fix venv
ca410a1 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin
Trigger on main
13ebc78 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin marked this pull request as ready for review November 17, 2025 21:25
@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed aarch64-cpu labels Nov 17, 2025
@mgoin mgoin changed the title Fix macos smoke test workflow Run macos smoke test workflow on main commit Nov 17, 2025
@DarkLight1337 DarkLight1337 merged commit 88ab591 into main Nov 18, 2025
22 checks passed
@DarkLight1337 DarkLight1337 deleted the macos-smoke-test-green branch November 18, 2025 03:16
@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 18, 2025

The smoke test often times out on main, PTAL

Victor49152 pushed a commit to Victor49152/vllm that referenced this pull request Nov 20, 2025
@mgoin @Victor49152
Run macos smoke test workflow on main commit (vllm-project#28752)
cb36479 
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
bigPYJ1151 pushed a commit that referenced this pull request Nov 25, 2025
@mgoin @bigPYJ1151
Run macos smoke test workflow on main commit (#28752)
62e5dd8 
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: jiang1.li <jiang1.li@intel.com>
bringlein pushed a commit to bringlein/vllm that referenced this pull request Nov 26, 2025
@mgoin @bringlein
Run macos smoke test workflow on main commit (vllm-project#28752)
a704238 
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@bigPYJ1151 bigPYJ1151 Awaiting requested review from bigPYJ1151

Assignees

No one assigned

Labels

aarch64-cpu ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgoin @DarkLight1337