Skip to content

[compile] Add fallback path to AOT compile when serialization fails. #27350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

[compile] Add fallback path to AOT compile when serialization fails. #27350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfa16f
[compile] Add fallback path to AOT compile when serialization fails.
zhxchen17 Oct 22, 2025
f67f5d2
Merge branch 'main' into zhxchen17/precompile/serialization_fallback
DarkLight1337 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions vllm/compilation/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,8 +402,17 @@ def patched_inline_call(self_):
output = self.aot_compiled_fn(self, *args, **kwargs)
assert aot_compilation_path is not None
assert cache_dir is not None
os.makedirs(cache_dir, exist_ok=True)
self.aot_compiled_fn.save_compiled_function(aot_compilation_path)
try:
os.makedirs(cache_dir, exist_ok=True)
self.aot_compiled_fn.save_compiled_function(
aot_compilation_path
)
except Exception as e:
logger.warning(
"Cannot save aot compilation to path %s, error: %s",
aot_compilation_path,
str(e),
)
Comment on lines +411 to +415
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For better debuggability, it's recommended to log the full traceback of the exception. This can be achieved by passing exc_info=True to the logger. It will help in diagnosing the root cause of serialization failures for the long-term fix. Also, you can pass the exception object e directly to the logger instead of str(e).

Suggested change
logger.warning(
"Cannot save aot compilation to path %s, error: %s",
aot_compilation_path,
str(e),
)
logger.warning(
"Cannot save aot compilation to path %s, error: %s",
aot_compilation_path,
e,
exc_info=True,
)

Copy link
Collaborator

@zou3519 zou3519 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhxchen17 try-catch on general exception generally not good, we're gonna want to remove this in the medium term.

else:
output = self.compiled_callable(*args, **kwargs)
return output
Expand Down