-
Notifications
You must be signed in to change notification settings - Fork 623
[Model] Add qwen3Next support in Main #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SunnyLee219 <3294305115@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for qwen3Next. The changes include adding a metadata parameter to the causal_conv1d_fn function and correcting a module path for monkey-patching in patch_triton.py. My review identifies a potential issue with the newly added metadata parameter in causal_conv1d_fn being unused, which could indicate an incomplete implementation. The path correction appears correct.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: SunnyLee219 <3294305115@qq.com>
What this PR does / why we need it?
Add Qwen3Next support in main
Does this PR introduce any user-facing change?
How was this patch tested?