Skip to content

Conversation

@SunnyLee151064
Copy link
Contributor

@SunnyLee151064 SunnyLee151064 commented Dec 1, 2025

What this PR does / why we need it?

Add Qwen3Next support in main

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: SunnyLee219 <3294305115@qq.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for qwen3Next. The changes include adding a metadata parameter to the causal_conv1d_fn function and correcting a module path for monkey-patching in patch_triton.py. My review identifies a potential issue with the newly added metadata parameter in causal_conv1d_fn being unused, which could indicate an incomplete implementation. The path correction appears correct.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@SunnyLee151064 SunnyLee151064 changed the title Add qwen3Next support in Main [Model] Add qwen3Next support in Main Dec 1, 2025
Signed-off-by: SunnyLee219 <3294305115@qq.com>
@wangxiyuan wangxiyuan added ready read for review ready-for-test start test by label for PR labels Dec 1, 2025
Signed-off-by: SunnyLee219 <3294305115@qq.com>
Signed-off-by: SunnyLee219 <3294305115@qq.com>
Signed-off-by: SunnyLee219 <3294305115@qq.com>
@yiz-liu yiz-liu merged commit 38bd952 into vllm-project:main Dec 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ops module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants