-
Notifications
You must be signed in to change notification settings - Fork 629
[draft]qwen3-omni online reference server bugfix #4584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Meihan-chen
wants to merge
4
commits into
vllm-project:main
Choose a base branch
from
Meihan-chen:qwen3-omni-bugfix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−20
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import pytest | ||
| from vllm import LLM, SamplingParams | ||
|
|
||
| MODEL_NAME = "Qwen/Qwen3-Omni-30B-A3B-Thinking" | ||
|
|
||
|
|
||
| @pytest.fixture(scope="function") | ||
| def llm_engine(): | ||
| llm = LLM( | ||
| model=MODEL_NAME, | ||
| tensor_parallel_size=4, | ||
| enable_expert_parallel=True, | ||
| trust_remote_code=True, | ||
| gpu_memory_utilization=0.90, | ||
| max_model_len=20480, | ||
| ) | ||
| return llm | ||
|
|
||
|
|
||
| def test_qwen_omni_multimodal_inputs(llm_engine): | ||
| # Sampling Parameters | ||
| sampling_params = SamplingParams(temperature=0.7, | ||
| top_p=0.8, | ||
| repetition_penalty=1.05, | ||
| max_tokens=512) | ||
|
|
||
| # multi-model inputs (OpenAI Chat Format) | ||
| messages = [{ | ||
| "role": | ||
| "user", | ||
| "content": [{ | ||
| "type": "image_url", | ||
| "image_url": { | ||
| "url": | ||
| "https://qianwen-res.oss-cn-beijing.aliyuncs.com/Qwen3-Omni/demo/cars.jpg" | ||
| }, | ||
| }, { | ||
| "type": "audio_url", | ||
| "audio_url": { | ||
| "url": | ||
| "https://qianwen-res.oss-cn-beijing.aliyuncs.com/Qwen3-Omni/demo/cough.wav" | ||
| } | ||
| }, { | ||
| "type": "video_url", | ||
| "video_url": { | ||
| "url": | ||
| "https://qianwen-res.oss-cn-beijing.aliyuncs.com/Qwen3-Omni/demo/draw.mp4" | ||
| } | ||
| }, { | ||
| "type": "text", | ||
| "text": "Analyze this audio, image, and video together." | ||
| }] | ||
| }] | ||
|
|
||
| outputs = llm_engine.chat(messages=messages, | ||
| sampling_params=sampling_params) | ||
|
|
||
| assert outputs is not None, "Output should not be None" | ||
| assert len(outputs) > 0, "Should return at least one output" | ||
|
|
||
| output_text = outputs[0].outputs[0].text | ||
| print( | ||
| f"\n[Output] Model generated text:\n{'-'*20}\n{output_text}\n{'-'*20}") | ||
|
|
||
| # Check whether the audio, image, and video content are correctly understood. | ||
| assert len(output_text.strip()) > 0, "Generated text should not be empty" | ||
| assert "cough" in output_text.lower() and "mercedes" in output_text.lower( | ||
| ) and "drawing" in output_text.lower() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for determining the attention state (
attn_state) has been commented out and hardcoded toAscendAttentionState.ChunkedPrefill. This will force all attention computations to use the chunked prefill path, which is incorrect for decode, speculative decoding, and other states. This change will likely lead to incorrect behavior and performance issues. This seems like a temporary debugging change that should be reverted before merging.