Skip to content

Conversation

@kyuyeunk
Copy link
Collaborator

@kyuyeunk kyuyeunk commented Nov 18, 2025

Description

Fix error due to upstream change in vllm-project/vllm#28771

Addresses #1115

Tests

https://buildkite.com/tpu-commons/tpu-inference-ci/builds/5580

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk kyuyeunk requested a review from QiliangCui November 18, 2025 06:56
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk kyuyeunk force-pushed the fix_to_list branch 3 times, most recently from d4d2909 to 9d14bf6 Compare November 18, 2025 08:21
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
@kyuyeunk kyuyeunk merged commit 45edde6 into main Nov 18, 2025
3 checks passed
@kyuyeunk kyuyeunk deleted the fix_to_list branch November 18, 2025 09:36
Lumosis added a commit that referenced this pull request Nov 21, 2025
…#1119)"

This reverts commit 45edde6.

Signed-off-by: Lihao Ran <imlihao.ran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants