[AWQ] modernized typehints, allow for n_grid/duo_scaling parameters #2003
+62
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
fynnsu
previously approved these changes
Nov 10, 2025
Collaborator
fynnsu
left a comment
fynnsu
left a comment
There was a problem hiding this comment.
Looks good! In the future these should probably be two separate prs but changes make sense to me.
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
brian-dellabetta
changed the title
kylesayrs
reviewed
Nov 10, 2025
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
kylesayrs
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This updates the AWQModifier type hints to python 3.10+, exposes n_grid as a parameter rather than the hard-coded 20, and allows the value of duo_scaling to be None, in which case half of the grid search is performed with duo_scaling off and the other half with duo_scaling on. This stems from @fynnsu 's findings that the previous default value of True was actually leading to worse behavior in some circumstances
TEST PLAN:
Run benchmarks with different values of n_grid and duo_scaling to see how much this affects accuracy/runtime