-
Notifications
You must be signed in to change notification settings - Fork 287
[MoE] Clean up imports, add qwen3_moe_vl, change logger level #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Mixture-of-Experts (MoE) calibration framework by integrating support for the qwen3_moe_vl model, thereby expanding the range of compatible models. It also addresses logging verbosity by downgrading a frequent log message to debug level, ensuring a cleaner console output during calibration. Additionally, the PR includes minor code refactorings to improve clarity and maintainability across several MoE-related files. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cleans up MoE calibration logic, reduces logging verbosity, and adds support for qwen3_moe_vl. The changes are generally good, improving code structure and readability. However, I've found a few critical issues with the new qwen3_vl_moe implementation that will cause runtime errors. Specifically, the module registration for calibration is incorrect, the deprecated replace function is broken, and the corresponding test is not set up correctly and would fail. Please see my detailed comments for suggestions on how to fix these issues.
|
FYI @sairampillai |
|
Looks awesome! @kylesayrs |
brian-dellabetta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@kylesayrs can you address conflicts? |
fynnsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
This reverts commit 6dd0320.
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
215b95c
2274444 to
215b95c
Compare
dsikka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on restore for the qwen3 vl moe
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Purpose
RegistryMixinfor registry functionality to make use of code reuseChanges
RegistryMixinfor registry functionalityCalibrateQwen3VLMoeTextSparseMoeBlockTesting