Skip to content

Conversation

@arthurfiorette
Copy link
Collaborator

@arthurfiorette arthurfiorette commented Dec 1, 2025

  • Removes jest/babel config files and dependencies
  • Switches glob to native fs.globSync
  • Moves invalid-data, config and vega-lite tests to its own folders/files
📦 Published PR as canary version: 2.4.1--canary.2419.6ef894b.0

✨ Test out this PR locally via:

npm install ts-json-schema-generator@2.4.1--canary.2419.6ef894b.0
# or 
yarn add ts-json-schema-generator@2.4.1--canary.2419.6ef894b.0

Copilot finished reviewing on behalf of arthurfiorette December 1, 2025 17:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the test framework from Jest to Node.js's built-in node:test, removes Babel configuration, and reorganizes test files into dedicated folders. It also attempts to replace the glob dependency with Node.js's native fs.globSync.

Key Changes:

  • Removed Jest and Babel dependencies and configuration files
  • Reorganized tests into test/valid-data, test/invalid-data, test/config, and test/vega-lite folders
  • Updated test names to include category prefixes (e.g., "valid-data - ", "config - ", "invalid-data - ")
  • Attempted migration from glob package to native fs.globSync

Reviewed changes

Copilot reviewed 291 out of 292 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
factory/program.ts Bug: Incorrect import of globSync from node:fs
test/utils.ts Refactored test helpers into assertValidSchema, assertConfigSchema, and assertInvalidSchema functions
test/valid-data/**/index.test.ts Added "valid-data - " prefix to all test names
test/invalid-data/**/index.test.ts New structure: moved from single file to individual test files per case
test/config/**/index.test.ts New structure: moved from single file to individual test files per config
test/vega-lite/vega-lite.test.ts Moved from root test directory to dedicated folder
package.json Removed glob, @babel/*, chai, jest dependencies; moved @typescript/vfs to devDependencies
jest.config.cjs Deleted (no longer using Jest)
babel.config.cjs Deleted (no longer using Babel)
eslint.config.mjs Removed Jest globals from test file configuration
.vscode/settings.json Removed Jest-specific settings
.prettierignore Removed Babel and Jest config files from ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants