Run dep smokechecker #486
Open
Run dep smokechecker #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
cli-checker
branch
2 times, most recently
from
003dfc8 to
042230f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 77.95% 77.63% -0.33%
==========================================
Files 14 15 +1
Lines 1901 1927 +26
Branches 401 406 +5
==========================================
+ Hits 1482 1496 +14
- Misses 272 283 +11
- Partials 147 148 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dency smoke test why: ensure runtime-only installs surface missing deps before release. what: - add typed script that imports all vcspull modules. - probe every CLI sub-command using --help to trigger entry points. - provide flags to skip phases and show verbose output.
why: allow CI to invoke runtime dependency smoke test via pytest marker. what: - add isolated test harness that shells out with uvx to run the script. - echo stdout/stderr when the subprocess fails for easier debugging.
why: runtime smoke test should only run when explicitly requested because it spawns uvx and needs network access. what: - add pytest_collection_modifyitems hook that skips items with scripts__runtime_dep_smoketest marker unless -m is passed.
why: ensure pytest discovers the new scripts tests and documents the opt-in marker. what: - add scripts directory to pytest testpaths so the new test file is collected. - declare scripts__runtime_dep_smoketest marker description.
why: contributors need guidance on exercising the isolated runtime dependency smoke test. what: - add section showing how to run the script via uvx and via the pytest marker. - call out that the check relies on network access.
…ndency why: keep runtime installs free of typing_extensions while still supporting optional fields. what: - split ConfigDict into required/optional TypedDict mixins instead of relying on NotRequired. - drop the typing_extensions import entirely.
why: ensure CI verifies vcspull installs without dev/test dependencies by running the new smoke script. what: - add step that invokes uvx in an isolated environment to run scripts/runtime_dep_smoketest.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.