Skip to content

Conversation

@ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Nov 6, 2025

Description

Quick draft of potential dpctl tensor support removal, follow-up to #2721. Further discussion TBD. This would at least include:

  • Updates to all GPU examples to remove dpctl tensors
  • Updates to GPU/SPMD test scope to remove dpctl tensors

Other updates included that may be pushed to a later update:

  • Updates to onedal datatypes and utils

Other work that may fall in similar scope:


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@david-cortes-intel
Copy link
Contributor

From the CI failures, looks like calls to is_dpctl_tensor need to be removed in more places.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onedal/datatypes/_data_conversion.py 50.00% 0 Missing and 1 partial ⚠️
onedal/utils/_array_api.py 0.00% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
azure 80.38% <33.33%> (-0.10%) ⬇️
github 81.98% <33.33%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/dummy/dummy.py 95.65% <ø> (ø)
onedal/utils/_third_party.py 88.46% <ø> (-0.43%) ⬇️
onedal/datatypes/_data_conversion.py 91.42% <50.00%> (-0.47%) ⬇️
onedal/utils/_array_api.py 90.24% <0.00%> (-0.67%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants