-
Notifications
You must be signed in to change notification settings - Fork 184
feature: add dev doc logic #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: add dev doc logic #2755
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
A couple questions here:
|
|
really good questions!
Entire planned workflow (any suggestions is welcomed!)
release mode: trigger by tag push
|
Got it. But for point 6) in the 1st part, since these docs take ~60mb each and we can expect a few thousands commits per year, it sounds like it will quickly start growing too much in size, which will make further downloads slower and might hit off size limits from github (not sure which tier we have). Is there some other way to handle the development docs that wouldn't result in as much space being consumed? For example, could they be deployed directly to github pages without storing them on the triggers from merges to main, and then downloaded from the current github pages (not git branch) on the triggers from releases? |
|
Or alternatively, since there would be regular pushes to the main branch either way, could the release doc just store them in the archive branch without deploying, and then the merge-to-main job pull from that branch and add the current development version? |
I still don't understand why it will consume a lot of space, since from every main merge we are just replacing the current dev docs. We could have a lot of commits but we are not storing each dev doc commit, just the latest main dev doc. We are also limiting the trigger on doc related changes, if a PR merges to main but does not change any doc, doc-release.yml will not be triggered either. |
Yes, but those would each be on a separate commit in the storage branch. And since git is not based off file differences, that would quickly start growing in size by a lot. |
Description
Dev doc is triggered when PR from main is merged.
Release doc is just cp existing content from dev doc to release version doc
Checklist:
Completeness and readability
Testing
Performance